[ldapvi] [PATCH] Don’t switch off canonical mode.

Matěj Cepl mcepl at cepl.eu
Fri Sep 8 18:30:02 CEST 2023


I am not sure what's the point, but certainly it leads to password
showing up in the audit log.
---
Reposting of incorrectly send patch (originally
http://lists.askja.de/pipermail/ldapvi/2018-January/000121.html).

 ldapvi/ldapvi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ldapvi/ldapvi.c b/ldapvi/ldapvi.c
index b594327..7c12717 100644
--- a/ldapvi/ldapvi.c
+++ b/ldapvi/ldapvi.c
@@ -97,7 +97,6 @@ cleanup(int rc, char *pathname)
 	if (tcgetattr(0, &term) == -1)
 		/* oh, running without a terminal */
 		return;
-	term.c_lflag |= ICANON;
 	term.c_lflag |= ECHO;
 	if (tcsetattr(0, TCSANOW, &term) == -1) syserr();
 }
@@ -1418,7 +1417,7 @@ write_file_header(FILE *s, cmdline *cmdline)
 		 * the "encoding" option affects more than just the file,
 		 * and a "fileencoding" doesn't actually seem exist.  Very
 		 * disappointing, but until a real solution turns up, it's
-		 * better to do nothing. */ 
+		 * better to do nothing. */
 		fputs("# -*- coding: utf-8 -*-\n", s);
 		nlines++;
 	}
-- 
2.42.0




More information about the ldapvi mailing list